Improve docs, small refactor of reconstruction measures#275
Merged
PicoCentauri merged 8 commits intoOct 29, 2025
Merged
Conversation
PicoCentauri
left a comment
PicoCentauri
left a comment
Collaborator
There was a problem hiding this comment.
Thanks a lot for the cleanup!
Can you maybe highlight the None as with backticks? I found a couple but probably I missed some.
Also, we could check removing the default from the docstring, if the rendering is good enough.
Co-authored-by: Philip Loche <philip.loche@posteo.de>
Co-authored-by: Philip Loche <philip.loche@posteo.de>
PicoCentauri
left a comment
PicoCentauri
left a comment
Collaborator
There was a problem hiding this comment.
Wonderful. Just a small test and we can merge.
PicoCentauri
approved these changes
Oct 29, 2025
PicoCentauri
left a comment
PicoCentauri
left a comment
Collaborator
There was a problem hiding this comment.
Awesome! Thanks @sofiia-chorna for your first commit to scikit-matter 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor (creator of PR) checklist
For Reviewer
📚 Documentation preview 📚: https://scikit-matter--275.org.readthedocs.build/en/275/