Sketchmap#284
Draft
sofiia-chorna wants to merge 18 commits into
Draft
Conversation
Collaborator
There was a problem hiding this comment.
We should at least add a regression test maybe based on a random dataset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chatty-based reimplementation of sketchmap
tested with the MAD test with original smap, the result is quite similar
for now, there is only
fit_transformmethod, for out-of-distribution data user needs to either do out-of-sample embedding or train a MLP (as done in MAD paper!).also, i tried to do the function that suggests parameters from https://sketchmap.org/index.html?page=tuts&psub=analysis but should be refined!
TODO:
Contributor (creator of PR) checklist
For Reviewer
📚 Documentation preview 📚: https://scikit-matter--284.org.readthedocs.build/en/284/