Skip to content

DOC: Update derivation equations of positive Group Lasso penalty#331

Open
Aishwarya0811 wants to merge 5 commits into
scikit-learn-contrib:mainfrom
Aishwarya0811:fix-positive-group-lasso-equations
Open

DOC: Update derivation equations of positive Group Lasso penalty#331
Aishwarya0811 wants to merge 5 commits into
scikit-learn-contrib:mainfrom
Aishwarya0811:fix-positive-group-lasso-equations

Conversation

@Aishwarya0811

@Aishwarya0811 Aishwarya0811 commented Aug 14, 2025 •
edited
Loading

Copy link
Copy Markdown

Context of the PR

Contributions of the PR

  • Complete mathematical derivation for the subdifferential case w = 0 including full Lagrangian formulation
  • Rigorous KKT conditions and complementary slackness analysis with step-by-step mathematical proof
  • Replacement of incomplete placeholder text with actual mathematical derivations from the reference document
  • Improved mathematical notation consistency throughout the tutorial
  • Complete mathematical derivation for the subdifferential case w = 0 including full Lagrangian formulation
  • Rigorous KKT conditions and complementary slackness analysis with step-by-step mathematical proof
  • Replacement of incomplete placeholder text with actual mathematical derivations from the reference document
  • Improved mathematical notation consistency throughout the tutorial

Co-authored-by: @malakazlan

Checks before merging PR

  • added documentation for any new feature
  • added unit tests
  • edited the what's new (if applicable)

@Badr-MOUFAD

Badr-MOUFAD commented Aug 14, 2025

Copy link
Copy Markdown
Collaborator

Thanks @Aishwarya0811 for the PR!

You mistakenly pushed the files _double_quadratic.py and test_double_quadratic.py, ... which are unrelated to this PR, can you remove them?

@Aishwarya0811

Aishwarya0811 commented Aug 14, 2025

Copy link
Copy Markdown
Author

Hi @Badr-MOUFAD!
Got it fixed! I removed those unrelated files - they were from my previous PR and somehow got mixed in here.
The PR is now clean and only has the documentation updates for issue #243.
Tests are all green, so it should be good to go. Let me know if you need any tweaks!

Thanks for the quick feedback 👍

malakazlan
malakazlan approved these changes Aug 21, 2025
View reviewed changes

@malakazlan malakazlan left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

documentation with formula is nicely done and correctly now .Thanks for contribution.

@Aishwarya0811

Aishwarya0811 commented Aug 21, 2025

Copy link
Copy Markdown
Author

Thank you @malakazlan for review on PR 😀

@Aishwarya0811

Aishwarya0811 commented Aug 21, 2025

Copy link
Copy Markdown
Author

@mathurinm @Badr-MOUFAD
I’ve cleaned up the PR as requested — it now only includes the updated derivations for positive Group Lasso (issue #243).
Would you mind taking another look and approving when you get a chance?
Thanks! 🙏

@mathurinm mathurinm closed this Sep 30, 2025
@mathurinm mathurinm reopened this Sep 30, 2025
mathurinm
mathurinm approved these changes Sep 30, 2025
View reviewed changes

@mathurinm mathurinm left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @Badr-MOUFAD can you have a quick look ?

Aishwarya0811 and others added 4 commits October 16, 2025 15:12
@Aishwarya0811 @malakazlan
DOC: Update derivation equations of positive Group Lasso penalty
cda40e1 
- Add complete Lagrangian derivation for case w = 0
- Include rigorous KKT conditions and optimality analysis
- Replace incomplete derivations with full mathematical proofs

Fixes scikit-learn-contrib#243
@Aishwarya0811 @malakazlan
Remove unrelated files from PR
0446aac
@Aishwarya0811 @malakazlan
DOC: Update derivation equations of positive Group Lasso penalty
290fc59 
- Add complete Lagrangian derivation for case w = 0
- Include rigorous KKT conditions and optimality analysis
- Replace incomplete derivations with full mathematical proofs

Fixes scikit-learn-contrib#243
@malakazlan
Remove unrelated files from docs PR
afeaa30
@Aishwarya0811 Aishwarya0811 force-pushed the fix-positive-group-lasso-equations branch from 80dfa87 to afeaa30 Compare October 16, 2025 10:30
@Aishwarya0811

Aishwarya0811 commented Oct 16, 2025

Copy link
Copy Markdown
Author

@mathurinm Thank you for the approval! CI checks have completed successfully. Ready to merge when convenient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mathurinm mathurinm mathurinm approved these changes
+1 more reviewer
@malakazlan malakazlan malakazlan approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Aishwarya0811 @Badr-MOUFAD @mathurinm @malakazlan