Skip to content

Commit 5af4224

Browse files
Apply suggestions from code review
Co-authored-by: DominikKamp <130753997+DominikKamp@users.noreply.github.com>
1 parent 8a1278b commit 5af4224

3 files changed

Lines changed: 4 additions & 3 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
## Unreleased
44
### Added
5-
- Added enableDebugSol, disableDebugSol, and check for WITH_DEBUG_SOLUTION flag
5+
- Added enableDebugSol() and disableDebugSol() for controlling the debug solution mechanism if DEBUGSOL=true
66
- More support for AND-Constraints
77
- Added support for knapsack constraints
88
- Added isPositive(), isNegative(), isFeasLE(), isFeasLT(), isFeasGE(), isFeasGT(), isHugeValue(), and tests

docs/build.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -161,6 +161,7 @@ To use debug information in PySCIPOpt you need to build it with the following co
161161
.. code-block::
162162
163163
export CFLAGS="-UNDEBUG"
164+
export CXXFLAGS="-UNDEBUG"
164165
python -m pip install .
165166
166167
.. note:: Be aware that you will need the debug library of the SCIP Optimization Suite for this to work

src/pyscipopt/scip.pxi

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7509,15 +7509,15 @@ cdef class Model:
75097509
enabled for the SCIP data structure.
75107510
"""
75117511
if not with_debug_solution:
7512-
raise RuntimeError("SCIP was not built with the WITH_DEBUG_SOLUTION flag. Please rebuild SCIP with this flag enabled.")
7512+
raise RuntimeError("SCIP must be built with `DEBUGSOL=true` to enable the debug solution mechanism.")
75137513
SCIPenableDebugSol(self._scip)
75147514

75157515
def disableDebugSol(self):
75167516
"""
75177517
Disables the debug solution mechanism.
75187518
"""
75197519
if not with_debug_solution:
7520-
raise RuntimeError("SCIP was not built with the WITH_DEBUG_SOLUTION flag. Please rebuild SCIP with this flag enabled.")
7520+
raise RuntimeError("SCIP must be built with `DEBUGSOL=true` to disable the debug solution mechanism.")
75217521
SCIPdisableDebugSol(self._scip)
75227522

75237523
def getConss(self, transformed=True):

0 commit comments

Comments
 (0)