copilot suggestions

Author: Joao-Dionisio

src/pyscipopt/scip.pxi

@@ -8105,8 +8105,9 @@ cdef class Model:
             coefficient ``lincoef`` associated with the same variable when it
             also appears linearly in the quadratic part.
         linterms : list of tuple
-            Pairs ``(var, coef)`` for variables that appear only in the pure, i.e.,
-            variables that do not participate in any quadratic or bilinear term.
+            Pairs ``(var, coef)`` for all variables with a nonzero linear
+            coefficient in the constraint, including variables that also
+            appear in quadratic or bilinear terms.
 
         """
         cdef SCIP_EXPR* expr
@@ -8550,7 +8551,7 @@ cdef class Model:
             farkas_coef = SCIPgetVarFarkasCoef(self._scip, var.scip_var)
             if self.getObjectiveSense() == "maximize":
                 farkas_coef = -farkas_coef
-        except:
+        except Exception:
             raise Warning("no farkas coefficient available for variable " + var.name)
         return farkas_coef
 

tests/test_nonlinear.py

@@ -290,13 +290,7 @@ def test_quad_coeffs():
 
 
 def test_quad_coeffs_mixed_linear_and_quadratic():
-    """ensure getTermsQuadratic exposes all linear coefficients
 
-    ``linterms`` contains purely linear variables (those that do not appear
-    in the quadratic part).  For variables that also appear quadratically,
-    their linear coefficients are stored in the ``lincoef`` component of
-    ``quadterms``.
-    """
     scip = Model()
 
     var1 = scip.addVar(name="var1", vtype='C', lb=None)
@@ -324,6 +318,8 @@ def test_quad_coeffs_mixed_linear_and_quadratic():
     assert lin_only["var4"] == 8
     assert lin_only["var3"] == 4
     assert lin_only["var2"] == -5
+    # var1 has no linear component and must not appear in linterms
+    assert "var1" not in lin_only or lin_only.get("var1", 0.0) == 0.0
 
     # For completeness, checking if the coefficients from reconstructing the full linear
     # coefficients from both linterms and quadterms match