Change name and better test

Author: Joao-Dionisio

src/pyscipopt/scip.pxi

@@ -2196,7 +2196,7 @@ cdef class Constraint:
         constype = bytes(SCIPconshdlrGetName(SCIPconsGetHdlr(self.scip_cons))).decode('UTF-8')
         return constype == 'knapsack'
 
-    def isLinearRepresentable(self):
+    def isLinearType(self):
         """
         Returns True if constraint can be represented as a linear constraint.
 
@@ -7308,7 +7308,7 @@ cdef class Model:
         cdef SCIP_Bool success
         constype = bytes(SCIPconshdlrGetName(SCIPconsGetHdlr(cons.scip_cons))).decode('UTF-8')
 
-        if cons.isLinearRepresentable():
+        if cons.isLinearType():
             return SCIPconsGetRhs(self._scip, cons.scip_cons, &success)
         elif constype == 'nonlinear':
             return SCIPgetRhsNonlinear(cons.scip_cons)
@@ -7351,7 +7351,7 @@ cdef class Model:
         cdef SCIP_Bool success
         constype = bytes(SCIPconshdlrGetName(SCIPconsGetHdlr(cons.scip_cons))).decode('UTF-8')
 
-        if cons.isLinearRepresentable():
+        if cons.isLinearType():
             return SCIPconsGetLhs(self._scip, cons.scip_cons, &success)
         elif constype == 'nonlinear':
             return SCIPgetLhsNonlinear(cons.scip_cons)

tests/test_cons.py

@@ -35,14 +35,15 @@ def test_getConsVals():
         x[i] = m.addVar("%i" % i, vtype="B")
 
     c1 = m.addCons(quicksum(x[i] for i in x) <= 1)
-    c2 = m.addConsKnapsack([x[i] for i in x], [1]*n_vars, 10)
+    c2 = m.addConsKnapsack([x[i] for i in x], [i for i in range(1, n_vars+1)], 10)
     vals1 = m.getConsVals(c1)
     vals2 = m.getConsVals(c2)
 
     assert len(vals1) == n_vars
     assert all(isinstance(v, float) for v in vals1)
     assert len(vals2) == n_vars
     assert all(isinstance(v, float) for v in vals2)
+    assert m.getConsVals(c2) == [i for i in range(1, n_vars+1)]
 
 def test_constraint_option_setting():
     m = Model()