Fix most compilation issues and warnings

Author: Joao-Dionisio

src/pyscipopt/event.pxi

@@ -39,7 +39,7 @@ cdef class Eventhdlr:
 
 
 # local helper functions for the interface
-cdef Eventhdlr getPyEventhdlr(SCIP_EVENTHDLR* eventhdlr) noexcept with gil:
+cdef Eventhdlr getPyEventhdlr(SCIP_EVENTHDLR* eventhdlr):
     cdef SCIP_EVENTHDLRDATA* eventhdlrdata
     eventhdlrdata = SCIPeventhdlrGetData(eventhdlr)
     return <Eventhdlr>eventhdlrdata

src/pyscipopt/scip.pxd

@@ -385,7 +385,7 @@ cdef extern from "scip/scip.h":
     ctypedef struct SCIP_ROW:
         pass
 
-    ctypedef struct SCIP_ROW_EXACT:
+    ctypedef struct SCIP_ROWEXACT:
         pass
 
     ctypedef struct SCIP_NLROW:
@@ -394,7 +394,7 @@ cdef extern from "scip/scip.h":
     ctypedef struct SCIP_COL:
         pass
 
-    ctypedef struct SCIP_COL_EXACT:
+    ctypedef struct SCIP_COLEXACT:
         pass
 
     ctypedef struct SCIP_SOL:
@@ -427,12 +427,6 @@ cdef extern from "scip/scip.h":
     ctypedef struct SCIP_PROPDATA:
         pass
 
-    ctypedef struct SCIP_PROPTIMING:
-        pass
-
-    ctypedef struct SCIP_PRESOLTIMING:
-        pass
-
     ctypedef struct SCIP_PRESOL:
         pass
 
@@ -484,9 +478,6 @@ cdef extern from "scip/scip.h":
     ctypedef struct SCIP_PRESOL:
         pass
 
-    ctypedef struct SCIP_HEURTIMING:
-        pass
-
     ctypedef struct SCIP_SEPA:
         pass
 
@@ -535,10 +526,10 @@ cdef extern from "scip/scip.h":
     ctypedef struct SCIP_LPI:
         pass
 
-    ctypedef struct BMS_BLKMEM:
+    ctypedef struct SCIP_LPEXACT:
         pass
 
-    ctypedef struct SCIP_EXPR:
+    ctypedef struct BMS_BLKMEM:
         pass
 
     ctypedef struct SCIP_EXPRHDLR:
@@ -2083,13 +2074,13 @@ cdef class Column:
     @staticmethod
     cdef create(SCIP_COL* scipcol)
 
-cdef class Column:
+cdef class ColumnExact:
     cdef SCIP_COLEXACT* scip_col_exact
     # can be used to store problem data
     cdef public object data
 
     @staticmethod
-    cdef create(SCIP_COLEXACT* scipcol_exact)
+    cdef create(SCIP_COLEXACT* scip_col_exact)
 
 cdef class Row:
     cdef SCIP_ROW* scip_row
@@ -2105,7 +2096,7 @@ cdef class RowExact:
     cdef public object data
 
     @staticmethod
-    cdef create(SCIP_ROWEXACT* sciprow_exact)
+    cdef create(SCIP_ROWEXACT* scip_row_exact)
 
 cdef class NLRow:
     cdef SCIP_NLROW* scip_nlrow

src/pyscipopt/scip.pxi

@@ -625,6 +625,31 @@ cdef class Column:
         return (self.__class__ == other.__class__
                 and self.scip_col == (<Column>other).scip_col)
 
+cdef class ColumnExact:
+    """Base class holding a pointer to corresponding SCIP_COLEXACT."""
+
+    @staticmethod
+    cdef create(SCIP_COLEXACT* scipcolexact):
+        """
+        Main method for creating a ColumnExact class. Is used instead of __init__.
+
+        Parameters
+        ----------
+        scipcolexact : SCIP_COLEXACT*
+            A pointer to the SCIP_COLEXACT
+
+        Returns
+        -------
+        col : ColumnExact
+            The Python representative of the SCIP_COLEXACT
+
+        """
+        if scipcolexact == NULL:
+            raise Warning("cannot create ColumnExact with SCIP_COLEXACT* == NULL")
+        col = ColumnExact()
+        col.scip_col_exact = scipcolexact
+        return col
+
 cdef class Row:
     """Base class holding a pointer to corresponding SCIP_ROW."""
 
@@ -909,6 +934,31 @@ cdef class Row:
         return (self.__class__ == other.__class__
                 and self.scip_row == (<Row>other).scip_row)
 
+cdef class RowExact:
+    """Base class holding a pointer to corresponding SCIP_ROW."""
+
+    @staticmethod
+    cdef create(SCIP_ROWEXACT* sciprowexact):
+        """
+        Main method for creating a RowExact class. Is used instead of __init__.
+
+        Parameters
+        ----------
+        sciprow : SCIP_ROWEXACT*
+            A pointer to the SCIP_ROWEXACT
+
+        Returns
+        -------
+        row : Row
+            The Python representative of the SCIP_ROWEXACT
+
+        """
+        if sciprowexact == NULL:
+            raise Warning("cannot create Row with SCIP_ROWEXACT* == NULL")
+        row_exact = RowExact()
+        row_exact.scip_row_exact = sciprowexact
+        return row_exact
+
 cdef class NLRow:
     """Base class holding a pointer to corresponding SCIP_NLROW."""
 
@@ -7615,7 +7665,6 @@ cdef class Model:
 
         """
         raise Warning("model.getDualMultiplier(cons) is deprecated: please use model.getDualsolLinear(cons)")
-        return self.getDualsolLinear(cons)
 
     def getDualfarkasLinear(self, Constraint cons):
         """