[ESSDIFFRACTION] Fix beer geometry#594
Merged
Merged
Conversation
github-actions
Bot
changed the title
|
Hi! Your PR was missing some labels 🔖 so I added them: essdiffraction |
nvaytet
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue was that detector 10 was loaded instead of detector 1.
Fix was to tighten the regex identifying the component.
We could consider rewriting the loader using McStasToX to avoid similar issues in the future.
But that might come with its own set of difficulties, so I'm not sure its worth it.