[CI] Publish nightly reduced data files#596
Conversation
|
Hi! Your PR was missing some labels 🔖 so I added them: CI |
|
Seems to work fine https://github.com/scipp/ess/releases/tag/reduced_data_nightly Integrated and analysis tests can fetch the files from stable urls like https://github.com/scipp/ess/releases/download/reduced_data_nightly/dream_reduced.cif going forward. |
| permissions: | ||
| contents: write | ||
| steps: | ||
| - uses: actions/checkout@v6 |
There was a problem hiding this comment.
Do we even need to checkout here?
| echo "Publishing ${#files[@]} file(s):" | ||
| printf ' %s\n' "${files[@]}" | ||
| gh release delete reduced_data_nightly --yes --cleanup-tag 2>/dev/null || true | ||
| gh release create reduced_data_nightly \ |
There was a problem hiding this comment.
What happens if we skip the delete step and just try to push new files to an existing release?
For example, when uploading the built docs as assets to a release, we use a different action that just add files to a release.
I wonder if you can replace files with that, and avoid having to create the release entirely (now that it has been created once)?
There was a problem hiding this comment.
There seems to be an option for overwriting:
overwrite false If an asset with the same name already exists, overwrite it.
There was a problem hiding this comment.
Another reason to maybe use the action to upload assets is that I seem to get a gh notification every time a release is made.
Just uploading would not add any noise to our inboxes.
|
This should work now: https://github.com/scipp/ess/releases/tag/reduced_data_nightly We edit the release instead of a new release so shouldn't create any more notifications. |
2 participants
First step for #591