Skip to content

Set PREV_VERSION to 13 on el10 PG 16 images#663

Open
ShimShtein wants to merge 1 commit into
sclorg:masterfrom
ShimShtein:fix_prev_version_docs_16
Open

Set PREV_VERSION to 13 on el10 PG 16 images#663
ShimShtein wants to merge 1 commit into
sclorg:masterfrom
ShimShtein:fix_prev_version_docs_16

Conversation

@ShimShtein

@ShimShtein ShimShtein commented Jul 1, 2026

Copy link
Copy Markdown

Fixes #661 The binaries inside the container for the previous version are from version 13, let's set the default ENV variables to match the packages.

Summary by CodeRabbit

  • Chores
    • Updated the PostgreSQL 16 container configuration to use PostgreSQL 13 as the referenced previous major version in supported image builds.
    • Applied the same environment setting update across both Linux image variants, with no other visible runtime or port changes.

Fixes sclorg#661
The binaries inside the container for the previous version are
from version 13, let's set the default ENV variables to match
the packages.
@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a02f3697-66ab-4985-b91c-da8adc215fd0

📥 Commits

Reviewing files that changed from the base of the PR and between f1c89bc and 0b4e201.

📒 Files selected for processing (2)
  • 16/Dockerfile.c10s
  • 16/Dockerfile.rhel10

📝 Walkthrough

Walkthrough

Both PostgreSQL 16 Dockerfiles (c10s and rhel10 variants) have their POSTGRESQL_PREV_VERSION environment variable value changed from 15 to 13, correcting the previous major version reference used for upgrade tooling.

Changes

PREV_VERSION correction

Layer / File(s) Summary
Update POSTGRESQL_PREV_VERSION value
16/Dockerfile.c10s, 16/Dockerfile.rhel10
POSTGRESQL_PREV_VERSION ENV setting changed from 15 to 13 in both Dockerfiles while POSTGRESQL_VERSION=16 remains unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Related issues: #661 (PostgreSQL 16 images based on EL10 have an incorrect POSTGRESQL_PREV_VERSION set)

Suggested labels: bug, el10

Suggested reviewers: phracek, praiskup

🐰 A hop, a fix, a tiny tweak,
from fifteen down to thirteen's peek,
the upgrade path now works just right,
my carrot patch sleeps sound tonight.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: updating PREV_VERSION to 13 for EL10 PostgreSQL 16 images.
Linked Issues check ✅ Passed The Dockerfile changes set POSTGRESQL_PREV_VERSION to 13 in both EL10 PostgreSQL 16 images, matching issue #661.
Out of Scope Changes check ✅ Passed The PR only updates the previous PostgreSQL version value in the two targeted Dockerfiles and adds no unrelated changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

Pull Request validation

Failed

🔴 Review - Missing review from a member (1 required)

Success

🟢 CI - All checks have passed


Triggered by Workflow Run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PostgreSQL 16 images based on EL10 have an incorrect POSTGRESQL_PREV_VERSION set

1 participant