Skip to content

[Devin] fix: change newsletter subscribe endpoint from GET to POST #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devin-ai-integration wants to merge 1 commit into
base: devin/bug-scan
Choose a base branch
from
Open

[Devin] fix: change newsletter subscribe endpoint from GET to POST #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions api/mock-server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,14 +54,17 @@ app.post("/api/cart", (req, res) => {
res.json({ success: true, productId, quantity, unitPrice });
});

// GET /api/newsletter/subscribe
// BUG: This endpoint is GET but the frontend should POST subscriber email.
// Using GET for a mutation violates REST semantics and means email could
// appear in server logs and browser history.
// POST /api/newsletter/subscribe
app.post("/api/newsletter/subscribe", (req, res) => {
const { email } = req.body;
if (!email) return res.status(400).json({ error: "email required" });
res.json({ success: true });
});

// Keep GET for backward compatibility but prefer POST
app.get("/api/newsletter/subscribe", (req, res) => {
const { email } = req.query; // BUG: email in query param, not request body
const { email } = req.query;
if (!email) return res.status(400).json({ error: "email required" });
console.log(`Subscribed: ${email}`); // BUG: PII in server logs
res.json({ success: true });
});

Expand Down