Skip to content

[Devin] fix: add user feedback to newsletter subscription form #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devin-ai-integration wants to merge 1 commit into
base: devin/bug-scan
Choose a base branch
from
Open

[Devin] fix: add user feedback to newsletter subscription form #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 20 additions & 8 deletions app/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,16 +27,25 @@ async function fetchCartCount() {
return data.count;
}

// --- BUG 2: newsletter submit silently fails ---
// The form handler prevents default but never actually submits or
// gives user feedback. No error thrown, no success state shown.
function NewsletterSection() {
const [email, setEmail] = useState("");
const [status, setStatus] = useState("idle");

function handleSubmit(e) {
async function handleSubmit(e) {
e.preventDefault();
// Missing: API call, success state, error handling, or any feedback to user
setEmail("");
if (!email) return;
setStatus("submitting");
try {
const response = await fetch(`/api/newsletter/subscribe?email=${encodeURIComponent(email)}`);
if (response.ok) {
setStatus("success");
setEmail("");
} else {
setStatus("error");
}
} catch {
setStatus("error");
}
}

return (
Expand All @@ -51,11 +60,14 @@ function NewsletterSection() {
type="email"
placeholder="your@email.com"
value={email}
onChange={e => setEmail(e.target.value)}
onChange={e => { setEmail(e.target.value); if (status !== "idle") setStatus("idle"); }}
required
/>
<button type="submit" className="newsletter-submit">Subscribe</button>
<button type="submit" className="newsletter-submit" disabled={status === "submitting"}>
{status === "submitting" ? "Subscribing…" : status === "success" ? "Subscribed!" : "Subscribe"}
</button>
</form>
{status === "error" && <p style={{color: "#fca5a5", marginTop: 8, fontSize: 13}}>Something went wrong. Please try again.</p>}
</div>
);
}
Expand Down