Skip to content

[Devin] fix: add type=button and aria attributes to sort button #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devin-ai-integration wants to merge 1 commit into
base: devin/bug-scan
Choose a base branch
from
+4 −4
Open

[Devin] fix: add type=button and aria attributes to sort button #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions app/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,14 +156,14 @@ function App() {
);
}

// BUG 6: Sort button has no accessible label and is missing type="button"
// In some browsers this causes the page to reload (treated as form submit)
// when the sort button is inside a form context. Also missing aria-pressed.
function SortButton() {
return (
<button // Missing: type="button", aria-pressed, aria-label
<button
type="button"
className={`sort-btn ${sortAsc ? "active" : ""}`}
onClick={() => setSortAsc(s => !s)}
aria-label={sortAsc ? "Sort by price descending" : "Sort by price ascending"}
aria-pressed={sortAsc}
>
Price {sortAsc ? "↑" : "↓"}
</button>
Expand Down