Skip to content

Use bulleted list for resources#186

Merged
mathieu-benoit merged 4 commits into
score-spec:mainfrom
toshi38:patch-1
Jun 4, 2025
Merged

Use bulleted list for resources#186
mathieu-benoit merged 4 commits into
score-spec:mainfrom
toshi38:patch-1

Conversation

@toshi38

@toshi38 toshi38 commented Jun 3, 2025

Copy link
Copy Markdown
Contributor

What is the motivation?

The docs where hard to read when type, class, id, params where on one line. Other areas and annotations use bullet points so standardize to that.

image

What does this change do?

Fix markdown with missing bullet points, so it doesn't run the field descriptions across one line when rendered.

What is your testing strategy?

Trivial change to docs, didn't test aside from reviewing code.

Is this related to any issues?

No

Have you read the Contributing Guidelines?

Fix markdown with missing bullet points, so it doesn't run the field descriptions across one line when rendered.

Signed-off-by: Stephen Lau <stephen@lau.engineering>

@mathieu-benoit mathieu-benoit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch and the fix, much appreciated!

I just requested 2 small changes, this will be ready to be merged then, thanks!

This will do something like this:
image

Comment thread content/en/docs/score specification/score-spec-reference.md Outdated
Comment thread content/en/docs/score specification/score-spec-reference.md Outdated
mathieu-benoit and others added 2 commits June 3, 2025 11:47
Standardize on similar style to `service` and `containers` sections.

Co-authored-by: Mathieu Benoit <mathieu-benoit@hotmail.fr>
Signed-off-by: Stephen Lau <stephen@lau.engineering>
@mathieu-benoit mathieu-benoit self-requested a review June 4, 2025 10:11
Comment thread content/en/docs/score specification/score-spec-reference.md
Signed-off-by: Mathieu Benoit <mathieu-benoit@hotmail.fr>
@mathieu-benoit mathieu-benoit self-requested a review June 4, 2025 10:19

@mathieu-benoit mathieu-benoit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mathieu-benoit mathieu-benoit merged commit db83d39 into score-spec:main Jun 4, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants