Skip to content

Commit f32abd8

Browse files
fix: resolve infinite recursion in Provisioner.Class(), Type(), and Description() (#483)
Signed-off-by: Siddhartha Singh <siddharthagithub0007@gmail.com>
1 parent dd9c954 commit f32abd8

2 files changed

Lines changed: 15 additions & 3 deletions

File tree

internal/provisioners/envprov/envprov.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -154,11 +154,11 @@ func (e *envVarResourceTracker) Type() string {
154154
}
155155

156156
func (p *Provisioner) Class() string {
157-
return p.Class()
157+
return "default"
158158
}
159159

160160
func (p *Provisioner) Type() string {
161-
return p.Type()
161+
return "environment"
162162
}
163163

164164
func (p *Provisioner) Outputs() []string {
@@ -178,7 +178,7 @@ func (e *envVarResourceTracker) Params() []string {
178178
}
179179

180180
func (p *Provisioner) Description() string {
181-
return p.Description()
181+
return ""
182182
}
183183

184184
var _ provisioners.Provisioner = (*Provisioner)(nil)

internal/provisioners/envprov/envprov_test.go

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,18 @@ import (
2727
func TestProvisioner(t *testing.T) {
2828
p := new(Provisioner)
2929

30+
t.Run("class returns default", func(t *testing.T) {
31+
assert.Equal(t, "default", p.Class())
32+
})
33+
34+
t.Run("type returns environment", func(t *testing.T) {
35+
assert.Equal(t, "environment", p.Type())
36+
})
37+
38+
t.Run("description returns empty string", func(t *testing.T) {
39+
assert.Equal(t, "", p.Description())
40+
})
41+
3042
t.Run("test match", func(t *testing.T) {
3143
assert.True(t, p.Match("environment.default#w.r"))
3244
assert.False(t, p.Match("environment.default#thing"))

0 commit comments

Comments
 (0)