Skip to content

feat: support map of files and volumes and mark array as deprecated#123

Merged
astromechza merged 2 commits into
mainfrom
121-feature-change-array-collections-to-key-value-if-order-is-not-important
Apr 12, 2025
Merged

feat: support map of files and volumes and mark array as deprecated#123
astromechza merged 2 commits into
mainfrom
121-feature-change-array-collections-to-key-value-if-order-is-not-important

Conversation

@astromechza

Copy link
Copy Markdown
Member

This implements the feature #121 to support maps of files and objects.

This is done with two changes:

  1. Move file/volume object to an entry in the #defs section and remove required target field.
  2. Use "oneOf" variants to support both map and arrays.

Signed-off-by: Ben Meier <ben.meier@humanitec.com>
@astromechza astromechza force-pushed the 121-feature-change-array-collections-to-key-value-if-order-is-not-important branch from 430ab5e to 0ab272e Compare January 15, 2025 13:45
Comment thread score-v1b1.json
Signed-off-by: Ben Meier <ben.meier@humanitec.com>

@chris-stephenson chris-stephenson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mathieu-benoit

Copy link
Copy Markdown
Contributor

@astromechza @chris-stephenson, before merging and just to make sure, is it generating breaking changes with existing implementations out there?

@mathieu-benoit

mathieu-benoit commented Apr 10, 2025

Copy link
Copy Markdown
Contributor

This should be good to merge as per my convo with @astromechza.

But this will need follow ups:

Let's document these before merging maybe?

The goal is to add warnings of deprecation, we don't want to block and break existing things.

Knowing that oneOf is avoiding breaking change by being retro-compatible.

@astromechza astromechza merged commit 94e3167 into main Apr 12, 2025
@mathieu-benoit mathieu-benoit deleted the 121-feature-change-array-collections-to-key-value-if-order-is-not-important branch April 16, 2025 11:02
@mathieu-benoit mathieu-benoit changed the title feat: support map of files and volumes and mark arrays as deprecated feat: support map of files and volumes and mark array as deprecated Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Change array collections to key-value if order is not important

3 participants