Skip to content

Commit 5329e52

Browse files
Phlogistiqueclaude
andauthored
Run Tests on PRs regardless of base branch (#46)
`branches: ['*']` looks like "all branches", but in GitHub's [filter pattern syntax](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet) the `*` glob does not match `/` — and `pull_request.branches` filters on the *base* branch. So the Tests workflow silently skipped any PR whose base branch contains a slash. Concretely: #45 is stacked on #42's `claude/...` branch and got no Tests run at all. Drop the filter — a bare `pull_request:` trigger covers every base branch. (`'**'` would too, but no filter says what it means.) The README's example workflows never had a filter, so no doc change is needed beyond the inline comment. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01JHvKryT4QUpHYdNq9YEQxX --- _Generated by [Claude Code](https://claude.ai/code/session_01JHvKryT4QUpHYdNq9YEQxX)_ Co-authored-by: Claude <noreply@anthropic.com>
1 parent 3314aa6 commit 5329e52

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

.github/workflows/tests.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ name: Tests
22

33
on:
44
pull_request:
5-
branches: ['*']
65

76
jobs:
87
unit-tests:

0 commit comments

Comments
 (0)