Skip to content

Commit 6e116c0

Browse files
committed
refactor: remove redundant GITHUB_TOKEN export
Only GH_TOKEN is needed - gh CLI uses it, and gh auth setup-git configures git to use gh credentials
1 parent 5f6f6a0 commit 6e116c0

1 file changed

Lines changed: 3 additions & 5 deletions

File tree

.claude/run-e2e-tests.sh

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -88,9 +88,8 @@ setup_git_and_gh() {
8888
# Disable commit signing for tests
8989
git config --global commit.gpgsign false
9090

91-
# Setup gh authentication
92-
export GITHUB_TOKEN="$(cat "$TOKEN_FILE")"
93-
export GH_TOKEN="$GITHUB_TOKEN"
91+
# Setup gh authentication (gh uses GH_TOKEN)
92+
export GH_TOKEN="$(cat "$TOKEN_FILE")"
9493

9594
log_info "Configuring gh auth..."
9695
gh auth setup-git
@@ -115,8 +114,7 @@ restore_git_config() {
115114
run_e2e_tests() {
116115
log_info "Running e2e tests..."
117116

118-
export GITHUB_TOKEN="$(cat "$TOKEN_FILE")"
119-
export GH_TOKEN="$GITHUB_TOKEN"
117+
# GH_TOKEN is already exported from setup_git_and_gh, no need to re-export
120118

121119
# Run the tests with a timeout
122120
if timeout 480 bash "$PROJECT_ROOT/tests/test_e2e.sh"; then

0 commit comments

Comments
 (0)