Skip to content

Commit 908602b

Browse files
authored
Reword conflict comment to avoid retargeting confusion (#31)
Adds a trailing sentence to the merge-conflict PR comment reassuring the reader that they only need to push their conflict resolution. Without it, a reader might assume they also need to run `gh pr edit --base` themselves, which would not work because the synthetic merge commit would not be produced.
1 parent dd31c3c commit 908602b

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

update-pr-stack.sh

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,7 @@ update_direct_target() {
9393
echo
9494
echo -n "I tried to merge "
9595
format_branch_list_for_text "${CONFLICTS[@]}"
96-
echo
97-
echo "into this branch while updating the PR stack and hit conflicts."
96+
echo " into this branch while updating the pull request stack and hit conflicts."
9897
echo
9998
echo "#### How to resolve"
10099
echo '```bash'
@@ -109,6 +108,8 @@ update_direct_target() {
109108
done
110109
echo "git push"
111110
echo '```'
111+
echo
112+
echo "Once you push, this action will resume and finish updating this pull request."
112113
} | log_cmd gh pr comment "$BRANCH" -F -
113114
# Create the label if it doesn't exist, then add it to the PR
114115
gh label create "$CONFLICT_LABEL" --description "PR needs manual conflict resolution" --color "d73a4a" 2>/dev/null || true

0 commit comments

Comments
 (0)