#255 - negative start index when adding attribute code#294
Open
CoreySutton wants to merge 4 commits into
Open
Conversation
Contributor
Author
|
PR for bug #255 |
scottdurow
requested changes
Jan 18, 2019
scottdurow
left a comment
scottdurow
left a comment
Owner
There was a problem hiding this comment.
Great stuff - have you run the unit tests?
Perhaps add an addition unit test specifically to test this behaviour.
Also - just a code style point - I try to use type inference where possible - I see you have changed the code to use specific types.
Contributor
Author
|
Cool beans. I'll run the tests, add some more and fix the code styling :-) |
Contributor
Author
|
I've fixed the code style, created some tests for |
|
Hi @scottdurow when will this fix be released? I'm getting the same issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.