Verify Celery 5.6.3 compatibility#845
Closed
mitchh456 wants to merge 2 commits into
Closed
Conversation
Scout's Celery instrumentation uses signal handlers exclusively (before_task_publish, task_prerun, task_postrun, task_failure) and does not call get_connection or interact with Celery's redis backend directly. The deprecated redis get_connection args removal in Celery 5.6.3 does not affect Scout. Closes scoutapp#837 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
Closing: reopening as a PR from origin instead of fork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/scout_apm/celery.py) for compatibility with Celery 5.6.3get_connectionor redis backend methodsget_connectionargs in Celery 5.6.3 does not affect Scoutget_connectionanywhereAudit details
Scout's Celery integration connects to these signals only:
before_task_publish— adds timestamp header for queue time trackingtask_prerun— creates tracked request and spantask_postrun— stops the spantask_failure— tags errors and reports to ErrorMonitorNo interaction with Celery's redis connection handling, worker pool internals, or backend storage.
The
tox.inidependency (celery!=4.4.4) has no upper bound, so Celery 5.6.3 is already being tested in CI when it resolves as the latest version.Test plan
Closes #837
🤖 Generated with Claude Code