make sure we don't set modified during init (#7417)

Author: MjnMixael

qtfred/src/mission/Editor.cpp

@@ -522,7 +522,7 @@ void Editor::unmark_all() {
 		numMarked = 0;
 		setupCurrentObjectIndices(-1);
 
-		missionChanged();
+		updateAllViewports();
 	}
 }
 void Editor::markObject(int obj) {
@@ -561,7 +561,7 @@ void Editor::unmarkObject(int obj) {
 			setupCurrentObjectIndices(-1);  // can't find one; nothing is marked.
 		}
 
-		missionChanged();
+		updateAllViewports();
 	}
 }
 
@@ -755,8 +755,6 @@ void Editor::selectObject(int objId) {
 	}
 
 	setupCurrentObjectIndices(objId);  // select the new object
-
-	missionChanged();
 }
 void Editor::updateAllViewports() {
 	// This takes all renderers and issues an update request for each of them. For now that is only one but this allows

qtfred/src/mission/dialogs/AsteroidEditorDialogModel.cpp

@@ -95,7 +95,7 @@ void AsteroidEditorDialogModel::initializeData()
 			debrisOptions.emplace_back(std::make_pair(Asteroid_info[i].name, static_cast<int>(i)));
 		}
 	}
-
+	_modified = false;
 }
 
 void AsteroidEditorDialogModel::update_internal_field()

qtfred/src/mission/dialogs/BackgroundEditorDialogModel.cpp

@@ -15,6 +15,11 @@ extern void parse_one_background(background_t* background);
 namespace fso::fred::dialogs {
 BackgroundEditorDialogModel::BackgroundEditorDialogModel(QObject* parent, EditorViewport* viewport)
 	: AbstractDialogModel(parent, viewport)
+{
+	initializeData();
+}
+
+void BackgroundEditorDialogModel::initializeData()
 {
 	auto& bg = getActiveBackground();
 	auto& bm_list = bg.bitmaps;
@@ -26,6 +31,7 @@ BackgroundEditorDialogModel::BackgroundEditorDialogModel(QObject* parent, Editor
 	if (!sun_list.empty()) {
 		_selectedSunIndex = 0;
 	}
+	_modified = false;
 }
 
 bool BackgroundEditorDialogModel::apply()

qtfred/src/mission/dialogs/BackgroundEditorDialogModel.h

@@ -170,6 +170,7 @@ class BackgroundEditorDialogModel : public AbstractDialogModel {
 	void setLightingProfileName(const SCP_string& name);
 
   private:
+	void initializeData();
 	void refreshBackgroundPreview();
 	static background_t& getActiveBackground();
 	starfield_list_entry* getActiveBitmap() const;

qtfred/src/mission/dialogs/BriefingEditorDialogModel.cpp

@@ -126,6 +126,7 @@ void BriefingEditorDialogModel::initializeData()
 	_currentTeam = 0;
 	_currentStage = 0;
 	_currentIcon = -1;
+	_modified = false;
 }
 
 void BriefingEditorDialogModel::stopSpeech()

qtfred/src/mission/dialogs/CommandBriefingDialogModel.cpp

@@ -39,6 +39,7 @@ void CommandBriefingDialogModel::initializeData()
 
 	_currentTeam = 0;  // default to the first team
 	_currentStage = 0; // default to the first stage
+	_modified = false;
 }
 
 void CommandBriefingDialogModel::gotoPreviousStage()

qtfred/src/mission/dialogs/DebriefingDialogModel.cpp

@@ -48,6 +48,7 @@ void DebriefingDialogModel::initializeData()
 
 	_currentTeam = 0;
 	_currentStage = 0;
+	_modified = false;
 }
 
 void DebriefingDialogModel::gotoPreviousStage()

qtfred/src/mission/dialogs/FictionViewerDialogModel.cpp

@@ -19,7 +19,7 @@ bool FictionViewerDialogModel::apply() {
 		_fictionViewerStages.clear();
 		Mission_music[SCORE_FICTION_VIEWER] = -1;
 	} else {
-		// Keep whatever you’ve edited in _fictionViewerStages
+		// Keep whatever you've edited in _fictionViewerStages
 		Mission_music[SCORE_FICTION_VIEWER] = _fictionMusic; // -1 for none is valid
 	}
 
@@ -52,6 +52,7 @@ void FictionViewerDialogModel::initializeData() {
 
 	// music is managed through the mission
 	_fictionMusic = Mission_music[SCORE_FICTION_VIEWER];
+	_modified = false;
 }
 
 const SCP_vector<std::pair<SCP_string, int>>& FictionViewerDialogModel::getMusicOptions()

qtfred/src/mission/dialogs/JumpNodeEditorDialogModel.cpp

@@ -117,6 +117,7 @@ void JumpNodeEditorDialogModel::initializeData()
 	}
 
 	Q_EMIT jumpNodeMarkingChanged();
+	_modified = false;
 }
 
 void JumpNodeEditorDialogModel::buildNodeList()

qtfred/src/mission/dialogs/MissionCutscenesDialogModel.cpp

@@ -57,6 +57,7 @@ void MissionCutscenesDialogModel::initializeData()
 
 	cur_cutscene = -1;
 	modelChanged();
+	_modified = false;
 }
 SCP_vector<mission_cutscene>& MissionCutscenesDialogModel::getCutscenes()
 {