prevent negative array index when AI has no target

Goober5000 · Goober5000 · commit 6c42d9cc8265 · 2025-05-08T02:37:24.000-04:00
diff --git a/code/scripting/api/objs/ship.cpp b/code/scripting/api/objs/ship.cpp
@@ -811,7 +811,7 @@ ADE_VIRTVAR(TargetSubsystem, l_Ship, "subsystem", "Target subsystem of ship.", "
 		}
 	}
 
-	return ade_set_args(L, "o", l_Subsystem.Set(ship_subsys_h(&Objects[aip->target_objnum], aip->targeted_subsys)));
+	return ade_set_args(L, "o", l_Subsystem.Set(ship_subsys_h(aip->target_objnum >= 0 ? &Objects[aip->target_objnum] : nullptr, aip->targeted_subsys)));
 }
 
 ADE_VIRTVAR(Team, l_Ship, "team", "Ship's team", "team", "Ship team, or invalid team handle if ship handle is invalid")

Original file line number	Diff line number	Diff line change
`@@ -811,7 +811,7 @@ ADE_VIRTVAR(TargetSubsystem, l_Ship, "subsystem", "Target subsystem of ship.", "`
`811`	`811`	`}`
`812`	`812`	`}`
`813`	`813`
`814`		`- return ade_set_args(L, "o", l_Subsystem.Set(ship_subsys_h(&Objects[aip->target_objnum], aip->targeted_subsys)));`
	`814`	`+ return ade_set_args(L, "o", l_Subsystem.Set(ship_subsys_h(aip->target_objnum >= 0 ? &Objects[aip->target_objnum] : nullptr, aip->targeted_subsys)));`
`815`	`815`	`}`
`816`	`816`
`817`	`817`	`ADE_VIRTVAR(Team, l_Ship, "team", "Ship's team", "team", "Ship team, or invalid team handle if ship handle is invalid")`