Fix Crash On selecting different ship types (#6920)

TheForce172 · web-flow · commit 726c954e3727 · 2025-08-10T13:25:02.000-04:00
diff --git a/qtfred/src/mission/dialogs/ShipEditor/ShipEditorDialogModel.cpp b/qtfred/src/mission/dialogs/ShipEditor/ShipEditorDialogModel.cpp
@@ -1366,7 +1366,7 @@ namespace fso {
 				return Editor::wing_is_player_wing(wing);
 			}
 
-			std::set<size_t> ShipEditorDialogModel::getShipOrders() const
+			const std::set<size_t> &ShipEditorDialogModel::getShipOrders() const
 			{
 				return ship_orders;
 			}
diff --git a/qtfred/src/mission/dialogs/ShipEditor/ShipEditorDialogModel.h b/qtfred/src/mission/dialogs/ShipEditor/ShipEditorDialogModel.h
@@ -182,7 +182,7 @@ class ShipEditorDialogModel : public AbstractDialogModel {
 	 * @param wing Takes an integer id of the wing
 	 */
 	static bool wing_is_player_wing(const int);
-	std::set<size_t> getShipOrders() const;
+	const std::set<size_t> &getShipOrders() const;
 
 	bool getTexEditEnable() const;
 	/**

Original file line number	Diff line number	Diff line change
`@@ -1366,7 +1366,7 @@ namespace fso {`
`1366`	`1366`	`return Editor::wing_is_player_wing(wing);`
`1367`	`1367`	`}`
`1368`	`1368`
`1369`		`- std::set<size_t> ShipEditorDialogModel::getShipOrders() const`
	`1369`	`+ const std::set<size_t> &ShipEditorDialogModel::getShipOrders() const`
`1370`	`1370`	`{`
`1371`	`1371`	`return ship_orders;`
`1372`	`1372`	`}`