fix bounds check

Goober5000 · Goober5000 · commit e0c4c3033f6f · 2025-05-08T02:37:33.000-04:00
diff --git a/code/scripting/api/objs/comm_order.cpp b/code/scripting/api/objs/comm_order.cpp
@@ -60,7 +60,7 @@ ADE_FUNC(selectItem, l_Comm_Item, nullptr, "Selects the item and either proceeds
 	if (!ade_get_args(L, "o", l_Comm_Item.Get(&current)))
 		return ADE_RETURN_FALSE;
 
-	if (current < 0 || current > Num_menu_items) {
+	if (current < 0 || current >= Num_menu_items) {
 		LuaError(L, "Lua tried to select squad message that is not valid!");
 		return ADE_RETURN_FALSE;
 	}

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ ADE_FUNC(selectItem, l_Comm_Item, nullptr, "Selects the item and either proceeds`
`60`	`60`	`if (!ade_get_args(L, "o", l_Comm_Item.Get(&current)))`
`61`	`61`	`return ADE_RETURN_FALSE;`
`62`	`62`
`63`		`- if (current < 0 \|\| current > Num_menu_items) {`
	`63`	`+ if (current < 0 \|\| current >= Num_menu_items) {`
`64`	`64`	`LuaError(L, "Lua tried to select squad message that is not valid!");`
`65`	`65`	`return ADE_RETURN_FALSE;`
`66`	`66`	`}`