fix(graphics): measure ellipsis before shrinking in force_fit_string (#7165)

* fix(graphics): measure ellipsis before shrinking in force_fit_string

* chore(comments): clarify why ellipsis measurement is needed before shrinking

Author: danielchristiancazares

code/graphics/software/font.cpp

@@ -590,12 +590,15 @@ namespace font
 				str[len] = ellipsis_char;
 			}
 
+			// measure with ellipsis before shrinking further (the ellipsis characters could be narrower than the characters they replaced)
+			gr_get_string_size(&w, nullptr, str, scale, len + ellipsis_len);
+
 			// move the ellipsis back until the whole string fits
 			while (len > 0 && w > max_width) {
 				--len;
 				str[len] = ellipsis_char;
 				gr_get_string_size(&w, nullptr, str, scale, len + ellipsis_len);
-			};
+			}
 
 			str[len + ellipsis_len] = 0;
 		}