-
Notifications
You must be signed in to change notification settings - Fork 182
Supernova sun glare and fade regressions #4152
Copy link
Copy link
Open
Labels
bugAn issue from unintended consequencesAn issue from unintended consequencesgraphicsA feature or issue related to graphics (2d and 3d)A feature or issue related to graphics (2d and 3d)regressionA bug introduced by a new feature that breaks something which used to work.A bug introduced by a new feature that breaks something which used to work.
Milestone
Metadata
Metadata
Assignees
Labels
bugAn issue from unintended consequencesAn issue from unintended consequencesgraphicsA feature or issue related to graphics (2d and 3d)A feature or issue related to graphics (2d and 3d)regressionA bug introduced by a new feature that breaks something which used to work.A bug introduced by a new feature that breaks something which used to work.
Type
Fields
Give feedbackNo fields configured for issues without a type.
Projects
StatusShow more project fields
High Impact
There are a few regression bugs that were introduced at some point -- including but possibly not limited to ffc14f5 -- related to how the sun glare is treated during the supernova impact.
The attached image sequence shows what it looks like in retail...
Sun_spotvariable is supposed to color the screen using the same mechanism as the red "pain flash".Part of this is due to the introduction of light shafts in the above referenced commit. When I modified
gr_lightshafts_enabled()to return false if a supernova was in progress, this almost entirely fixed the problem - the glare behaved as it was supposed to. However there are still two deficiencies: