Enhancements to the FSO electrical arc system#6347
Merged
Goober5000 merged 7 commits intoJun 30, 2025
Conversation
Goober5000
added
enhancement
Goober5000
force-pushed
the
electrical_arc_enhancements
branch
3 times, most recently
from
947eb17 to
7c45fb3
Compare
Goober5000
force-pushed
the
electrical_arc_enhancements
branch
from
7c45fb3 to
2606d31
Compare
Goober5000
force-pushed
the
electrical_arc_enhancements
branch
from
2606d31 to
fdc9c7c
Compare
Goober5000
removed
the
Waiting for Stable
Goober5000
force-pushed
the
electrical_arc_enhancements
branch
from
fdc9c7c to
9563ba3
Compare
Baezon
requested changes
May 17, 2025
Baezon
left a comment
Baezon
left a comment
Member
There was a problem hiding this comment.
Looks mostly good to me, lots of good cleanup.
wookieejedi
approved these changes
May 26, 2025
wookieejedi
left a comment
wookieejedi
left a comment
Member
There was a problem hiding this comment.
Tests have showed things work as expected, and overall will be quite useful to have this extra augmentation to arcs.
The code for generating spark sounds was incorrectly copied from debris to ships, dating all the way back to retail. The sound should be played once per generation event, not once for every electrical arc active on the ship. This fixes a bug that caused overlapping electrical arc sounds.
…depth and using persistent arc points
…nction with a handy valueToVec3d utility function
Goober5000
force-pushed
the
electrical_arc_enhancements
branch
from
9563ba3 to
c5d5a93
Compare
Baezon
approved these changes
Jun 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several enhancements to make the electrical arcs more useful and flexible.
next_fireballandfire_timeoutin the debris structure misleadingly implied fireballs rather than arcs; these have been renamed to match the usage in shipsAs part of 6), a new
valueToVec3dutility method has been added that could be useful for future API functions.