Lab dock tester#6715
Merged
Merged
Conversation
MjnMixael
added
enhancement
MjnMixael
force-pushed
the
lab_dock_tester
branch
from
4a0eb63 to
41d800c
Compare
MjnMixael
force-pushed
the
lab_dock_tester
branch
from
41d800c to
8846589
Compare
MjnMixael
force-pushed
the
lab_dock_tester
branch
from
8846589 to
5a051e1
Compare
JohnAFernandez
requested changes
Jun 11, 2025
JohnAFernandez
approved these changes
Jun 11, 2025
Member
|
Awesome! Will plan to merge tomorrow pending any other requests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My final (for now) Lab PR. This adds the ability to test ship docking and undocking.
Basically there were two base requirements to get this functioning in the lab. Working AI and a valid
Player_shippointer. Toggling AI on is pretty easy so this toggles it on only when we're viewing a ship. I tested that this does not interfere with the turret firing test option. The AI code expects a valid Player_ship all over the place so in lieu of adding a ton extra checks for a valid pointer it seemed easy enough to simply set the current lab ship as the Player_ship. Kinda hacky but it does work. A play-dead order is required also but works.From there it spawns a docking ship and issues the dock order. The existing AI code does the rest.
Note that collisions are intentionally turned off because this is meant to test dock animations and dock locations. Turning collisions and physics on in the lab requires a whole other set of things to be initialized and we just don't need to do that here.
Relies on #6710 just because I wrote these in order on top of each other to avoid conflicts.