Fix vulkan build and enable it for Linux CI (retry of #6709)#6719
Closed
vmedea wants to merge 3 commits into
Closed
Fix vulkan build and enable it for Linux CI (retry of #6709)#6719vmedea wants to merge 3 commits into
vmedea wants to merge 3 commits into
Conversation
In 133b033, SCP_vector was made into a subclass, so direct assignment from the vulkan-hpp result isn't possible anymore. Use an intermediate vector.
Because these functions can return statuses that aren't strictly an error (and thus don't raise an exception), but might have to be handled, they return a `vk::Result` that's `[[nodiscard]]`. Ideally some of the result statuses would be handled here, but to get it to compile, cast the result to void.
Change to the new image that has the Vulkan headers, and enable building with Vulkan by default in the cmake options.
Contributor
Author
|
No, they're here as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying if opening a new PR gets rid of the phantom linux builds...
(see #6709)