enhance scripted time library a bit#6725
Merged
Merged
Conversation
Goober5000
added
enhancement
Goober5000
force-pushed
the
time_lib_stuff
branch
11 times, most recently
from
350afc2 to
c61734f
Compare
Add `UINT64_T_ARG` and `INT64_T_ARG` macros for printf arguments, similar to `SIZE_T_ARG` and `PTRDIFF_T_ARG`. In the process, fix some issues with the toolchain: in certain CI runs the toolchain headers were being #included multiple times, and certain CI runs produced collisions between clang definitions and gcc definitions. Resolve these issues with `#pragma once` and preprocessor guards in the event of both gcc and clang being active. Also remove toolchain.h from sexp_container.cpp since it is already #included via pstypes.h.
1. Add __tostring functions for both the `l_Timestamp` and `l_TimeSpan` types 2. Add a `getSeconds` function for the `l_Timestamp` type
Goober5000
force-pushed
the
time_lib_stuff
branch
from
c61734f to
778e2a5
Compare
wookieejedi
approved these changes
Jun 5, 2025
wookieejedi
left a comment
wookieejedi
left a comment
Member
There was a problem hiding this comment.
Straightforward and things worked as expected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some closely related changes:
l_Timestampandl_TimeSpantypesgetSecondsfunction for thel_TimestamptypeTested with a local Scroll script. Also:
UINT64_T_ARGandINT64_T_ARGmacros for printf arguments, similar toSIZE_T_ARGandPTRDIFF_T_ARG.In the process, fix some issues with the toolchain: in certain CI runs the toolchain headers were being #included multiple times, and certain CI runs produced collisions between clang definitions and gcc definitions. Resolve these issues with
#pragma onceand preprocessor guards in the event of both gcc and clang being active.Also remove toolchain.h from sexp_container.cpp since it is already #included via pstypes.h.