scale effects for muzzle and hits#6731
Merged
wookieejedi merged 3 commits intoMay 27, 2025
Merged
Conversation
wookieejedi
added
cleanup
wookieejedi
reviewed
May 22, 2025
wookieejedi
approved these changes
May 26, 2025
wookieejedi
left a comment
wookieejedi
left a comment
Member
There was a problem hiding this comment.
Overall this looks straightforward and good to me, though I'll hold off approving and merging for a day or so in-case @BMagnu or any others wanted to give it a quick pass.
Member
|
Bmagnu stated this also looked good, so I'll plan to merge later today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds proper curve scaling by trigger radius for muzzle effects and hit effects.