Still allow subsystem animations in the lab#6898
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #6715 added the ability to test docking and undocking the lab which required initializing the ai subsystem in the Lab as well. Doing that had a side effect of causing the current ship to move around on it's own. To solve that a Play-Dead order was issued. That had a side effect of causing subsystem rotations/translations to stop running as that is a design of Play-Dead.
Stay-Still didn't really work well on fighters in the Lab because they still wiggled around. So the options were to either constantly reset the current object's orientation every frame or just carve out a special case for the Lab to still run subsystem animations even during Play-Dead. The latter turned out to be the easiest and less hacky.
Fixes #6897