fix stats sync in multiplayer#7486
Merged
Goober5000 merged 1 commit intoMay 30, 2026
Merged
Conversation
A quick bugfix, thanks to Claude. Make sure the end of the loop is correctly offset from the start.
Goober5000
added
fix
JohnAFernandez
approved these changes
May 30, 2026
JohnAFernandez
left a comment
JohnAFernandez
left a comment
Contributor
There was a problem hiding this comment.
This appears to fix it. I don't think we were aware of this bug, but it might cause the sever to crash or get garbage packet data if the player joining had any kills to send.
Contributor
|
And it shouldn't need a Multi version bump or any other kind of handling, as it fixes the packet alignment to be the same on client and server. |
Contributor
Author
|
Cool. 👍 Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A quick bugfix, thanks to Claude. Make sure the end of the loop is correctly offset from the start.