clip the supernova whiteout to the letterbox#7493
Merged
Merged
Conversation
game_render_hud calls gr_reset_clip() before game_flash_diminish, so the sunspot palette flash was painting over the black bars during the supernova camera cut. Re-apply the letterbox clip around gr_flash when it would otherwise overdraw the bars (supernova HIT+ or GM_DEAD), matching the condition already used in game_set_view_clip. Partial fix for scp-fs2open#4152. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
BMagnu
reviewed
Jun 2, 2026
Per @BMagnu's review feedback on scp-fs2open#7493: factor the yborder calculation and clip-rect application into two file-local helpers so future changes to the letterbox proportions live in one place. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
BMagnu
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
game_render_hud calls gr_reset_clip() before game_flash_diminish, so the sunspot palette flash was painting over the black bars during the supernova camera cut. Re-apply the letterbox clip around gr_flash when it would otherwise overdraw the bars (supernova HIT+ or GM_DEAD), matching the condition already used in game_set_view_clip.
Partial fix for #4152. Tested on the retail Apocalypse mission.