Fix Shadow "Halo"#7494
Merged
Merged
Conversation
BMagnu
added
fix
JohnAFernandez
approved these changes
Jun 2, 2026
JohnAFernandez
left a comment
JohnAFernandez
left a comment
Contributor
There was a problem hiding this comment.
Looks straightforward enough.
wookieejedi
approved these changes
Jun 2, 2026
Member
|
Tests look good, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4465.
Seems like you need to do the computeShadowFactor before averaging or you get artifacts.
Since its no longer necessary, it also clears the cockpit pass and just changes the bias to a lower value when we render the cockpit pass.