FIx shadow banding on cockpits#7495
Merged
Merged
Conversation
wookieejedi
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #7245.
Turns out "but no cockpit actually needs micrometer or even nanometer precision" was an incorrect assumption, as this level of precision is needed to avoid shadow banding at very shallow light angles.
Fortunately, this is a very easy fix.
We just switch to linear handling in the closest accuracy band (thanks to Wookiee for the idea and find).
This will reduce the accuracy at 10m compared to Z-compressed, but not below what the accuracy was before Z-compression was introduced.
This will also not increase the accuracy of very close geometry to / beyond of what it was originally, but it will increase it beyond what it was with Z-compression.
In effect, this will just reshuffle some 10m accuracy to the sub-meter range in a linear fashion instead of in an equidistant fashion. This should remove any shadow banding in the cockpit range, while not reducing visual fidelity beyond what it was before Z-compression.
Any other parts of Z-compression, like long-distance view support or increased accuracy in the main battle lighting resolution are untouched and continue to work.