Restructure resolve_parse_flags into table-driven core + wrapper#7503
Open
Goober5000 wants to merge 1 commit into
Open
Restructure resolve_parse_flags into table-driven core + wrapper#7503Goober5000 wants to merge 1 commit into
Goober5000 wants to merge 1 commit into
Conversation
The ~70-line if-cascade collapses to a walk over a new Parse_object_flag_targets table mapping each parse flag to its object/ship/AI runtime counterpart; SF_Locked and OF_No_collide remain as hand-coded irregular cases. Split into a pure flagset->flagset inner overload (the table walk) and an outer wrapper that owns all context-dependent cases: the player-start gate, immobile soft-deprecation, MP red-alert override, shield-strength resolution, reinforcement-in-wing warning, and the no-shields/force-shields-on inconsistency warning. Move kamikaze damage and Knossos_warp_ani_used side effects to parse_create_object_sub's post-processing block. Update FRED's and qtFRED's create_ship for the new signature. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Goober5000
added
refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ~70-line if-cascade collapses to a walk over a new Parse_object_flag_targets table mapping each parse flag to its object/ship/AI runtime counterpart; SF_Locked and OF_No_collide remain as hand-coded irregular cases.
Split into a pure flagset->flagset inner overload (the table walk) and an outer wrapper that owns all context-dependent cases: the player-start gate, immobile soft-deprecation, MP red-alert override, shield-strength resolution, reinforcement-in-wing warning, and the no-shields/force-shields-on inconsistency warning.
Move kamikaze damage and Knossos_warp_ani_used side effects to parse_create_object_sub's post-processing block. Update FRED's and qtFRED's create_ship for the new signature.