Add safeguards for invalidated model instances#7521
Closed
BMagnu wants to merge 2 commits into
Closed
Conversation
Member
Author
|
Superceded by #7522. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the crash for SF:EH that happens sometimes on mission exit.
Also, this is notably just a bandaid fix.
It'll stop the crash for now, but there's an underlying issue that needs resolving.
The Ship_registry will contain valid entries for ships, the objects of which have been deleted. This causes all sorts of trouble, and there's a few ways to mitigate this: Make Ship_registry accesses query for validity of the ships still inside, or make mission deallocation / obj_delete_all / ship_cleanup hard-nuke the entire registry. However, both of these are fairly deep-rooted changes, so they're not great for RCs, and I'd rather just go with the bandaid for now, and properly fix this early in the next nightly phase.