Fix shadow artifacts by employing hardware clamping#7532
Merged
Conversation
BMagnu
added
fix
wookieejedi
approved these changes
Jun 17, 2026
wookieejedi
left a comment
wookieejedi
left a comment
Member
There was a problem hiding this comment.
Tests confirm this fixes the issue and everything else looks as it should, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some models with long, unbroken faces experience geometry artifacts if their faces get partly clamped and "squished" by the shadow cascades. This can be fixed by using hardware clamping, causing shadows to no longer be wildly incorrect in certain cases and camera angles. Extracts the idea of the last commit f6e65d8 of #7529 and packages it as a bugfix that can go into the current RC.