Add event and message reordering to the FRED event editor#7539
Draft
Goober5000 wants to merge 2 commits into
Draft
Add event and message reordering to the FRED event editor#7539Goober5000 wants to merge 2 commits into
Goober5000 wants to merge 2 commits into
Conversation
Goober5000
added
enhancement
Event annotations cache the tree item they point to as a handle (HTREEITEM in FRED, QTreeWidgetItem* in qtFRED). The handle was silently invalidated whenever the tree control deleted-and-recreated an item, so annotations got decoupled. Fix: notify when a node's handle changes. move_branch reports old->new, and free_node2 / the root-delete path report old->null (deleted). The event tree remaps the annotation's handle to follow a move, or clears it on delete (the path is left intact, so a cleared annotation is dropped at save but survives a Cancel). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Add "Move to top / up / down / to bottom" controls -- vertical icon-button strips beside both the event tree and the message list -- so events and messages can be reordered in place. Also add an "Insert Msg" button that inserts a message at the current selection, mirroring the existing "Insert Event". Tweak the message-area layout, drop the "Messages" label, and edit the AFX_DIALOG_LAYOUT table for proper behavior when the dialog is resized. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Goober5000
force-pushed
the
feature/reorder_messages_events
branch
from
d9d4e8f to
91c6ab9
Compare
|
Noice! I was going to request this but you done beat me to it. It's a good thing 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add "Move to top / up / down / to bottom" controls -- vertical icon-button strips beside both the event tree and the message list -- so events and messages can be reordered in place.
Also add an "Insert Msg" button that inserts a message at the current selection, mirroring the existing "Insert Event".
Tweak the message-area layout, drop the "Messages" label, and edit the AFX_DIALOG_LAYOUT table for proper behavior when the dialog is resized.
Depends on #7538; in draft until that is merged.