cpufreq: loongson2: Unregister platform_driver on failure

Yuan Can · gregkh · commit b2073db65ab3 · 2024-12-14T19:51:01.000+01:00
[ Upstream commit 5f856d7 ] When cpufreq_register_driver() returns error, the cpufreq_init() returns without unregister platform_driver, fix by add missing platform_driver_unregister() when cpufreq_register_driver() failed. Fixes: f8ede0f ("MIPS: Loongson 2F: Add CPU frequency scaling support") Signed-off-by: Yuan Can <yuancan@huawei.com> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
diff --git a/drivers/cpufreq/loongson2_cpufreq.c b/drivers/cpufreq/loongson2_cpufreq.c
@@ -154,7 +154,9 @@ static int __init cpufreq_init(void)
 
 	ret = cpufreq_register_driver(&loongson2_cpufreq_driver);
 
-	if (!ret && !nowait) {
+	if (ret) {
+		platform_driver_unregister(&platform_driver);
+	} else if (!nowait) {
 		saved_cpu_wait = cpu_wait;
 		cpu_wait = loongson2_cpu_wait;
 	}

Original file line number	Diff line number	Diff line change
`@@ -154,7 +154,9 @@ static int __init cpufreq_init(void)`
`154`	`154`
`155`	`155`	`ret = cpufreq_register_driver(&loongson2_cpufreq_driver);`
`156`	`156`
`157`		`- if (!ret && !nowait) {`
	`157`	`+ if (ret) {`
	`158`	`+ platform_driver_unregister(&platform_driver);`
	`159`	`+ } else if (!nowait) {`
`158`	`160`	`saved_cpu_wait = cpu_wait;`
`159`	`161`	`cpu_wait = loongson2_cpu_wait;`
`160`	`162`	`}`