Make code upto date with latest version of scrapy#36
Open
rabinadk1 wants to merge 10 commits intoscrapy-plugins:masterfrom
Open
Make code upto date with latest version of scrapy#36rabinadk1 wants to merge 10 commits intoscrapy-plugins:masterfrom
rabinadk1 wants to merge 10 commits intoscrapy-plugins:masterfrom
Conversation
BaseItem as deprecated in the favor of Item
BaseItem is deprecated in the favor of Item
Codecov Report
@@ Coverage Diff @@
## master #36 +/- ##
=========================================
Coverage ? 94.20%
=========================================
Files ? 2
Lines ? 69
Branches ? 9
=========================================
Hits ? 65
Misses ? 1
Partials ? 3 Continue to review full report at Codecov.
|
pawelmhm
reviewed
Mar 4, 2021
| raise NotConfigured('bsddb3 is required') | ||
| self.dbmodule = dbmodule | ||
| def __init__(self, dir: str, reset: bool = False, stats: StatsCollector = None): | ||
| self.dir = dir |
Collaborator
There was a problem hiding this comment.
bsddb3 is not available on some platforms, so it will crash for some people without bsddb3 and they will not know exactly why. I created ticket for moving away from bsddb3 to other library #37
Author
There was a problem hiding this comment.
Sorry for the late reply. But bsddb3 is imported on the top which will clearly say
import bsddb3
ModuleNotFoundError: No module named 'bsddb3'
when it is not installed on the device
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Iteminstead ofBaseItemsince it's deprecated in favor of the priorf-stringsBlacked the code to make it look good