Skip to content

Commit abff17b

Browse files
committed
Update crashed browser tests to run on Windows
1 parent a0dfd8b commit abff17b

1 file changed

Lines changed: 2 additions & 9 deletions

File tree

tests/tests_asyncio/test_browser.py

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import asyncio
22
import logging
3-
import platform
43
import random
54
import re
65
import subprocess
@@ -192,10 +191,7 @@ async def test_browser_closed_restart(self):
192191
== 2 # one at the beginning, one after calling Browser.close() manually
193192
)
194193

195-
@pytest.mark.skipif(
196-
platform.system() == "Windows",
197-
reason="os.kill does not work as expected on Windows",
198-
)
194+
@allow_windows
199195
async def test_browser_crashed_restart(self):
200196
spider = Spider("foo")
201197
async with make_handler(settings_dict={"PLAYWRIGHT_BROWSER_TYPE": "chromium"}) as handler:
@@ -239,10 +235,7 @@ async def test_browser_crashed_restart(self):
239235
== 2 # one at the beginning, one after killing the broser process
240236
)
241237

242-
@pytest.mark.skipif(
243-
platform.system() == "Windows",
244-
reason="os.kill does not work as expected on Windows",
245-
)
238+
@allow_windows
246239
async def test_browser_crashed_do_not_restart(self):
247240
spider = Spider("foo")
248241
settings_dict = {

0 commit comments

Comments
 (0)