Skip to content

fix: OnSuccess and onError added to saveProjectThumbnail#541

Merged
hgeorgiev-creator merged 1 commit intodevelopfrom
fix/gui-storage-interface-update
Apr 24, 2026
Merged

fix: OnSuccess and onError added to saveProjectThumbnail#541
hgeorgiev-creator merged 1 commit intodevelopfrom
fix/gui-storage-interface-update

Conversation

@hgeorgiev-creator
Copy link
Copy Markdown
Contributor

Resolves

In the GUIStorage interface adds the onSuccess and onError callbacks for the saveProjectThumbnail

Proposed Changes

Describe what this Pull Request does

Reason for Changes

Explain why these changes should be made

Test Coverage

Please show how you have added tests to cover your changes

@hgeorgiev-creator hgeorgiev-creator requested a review from a team as a code owner April 24, 2026 08:22
@hgeorgiev-creator hgeorgiev-creator changed the title fix: onsuccess and onerror added to the saveprojectthumbnail fix: OnSuccess and onError added to saveProjectThumbnail Apr 24, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 24, 2026

Test Results

  3 files   -     5   69 suites   - 1 014   11m 5s ⏱️ - 1m 2s
403 tests  - 2 317  395 ✅  - 2 317  8 💤 ± 0  0 ❌ ±0 
425 runs   - 5 848  417 ✅  - 5 817  8 💤  - 31  0 ❌ ±0 

Results for commit 76a7919. ± Comparison against base commit 62488f5.

This pull request removes 2317 tests.
buildLibraries Should NOT fill global assets from sprites if fillAssetsFromSprites is false ‑ buildLibraries Should NOT fill global assets from sprites if fillAssetsFromSprites is false
buildLibraries Should NOT inherit costume tags from sprites if costume already has tags ‑ buildLibraries Should NOT inherit costume tags from sprites if costume already has tags
buildLibraries Should NOT inherit sound tags from sprites ‑ buildLibraries Should NOT inherit sound tags from sprites
buildLibraries Should always extract dataFormat from file extension ‑ buildLibraries Should always extract dataFormat from file extension
buildLibraries Should deduplicate assets with the same name, ignoring casing ‑ buildLibraries Should deduplicate assets with the same name, ignoring casing
buildLibraries Should fill global costumes from sprites if fillAssetsFromSprites is true ‑ buildLibraries Should fill global costumes from sprites if fillAssetsFromSprites is true
buildLibraries Should fill sounds from global libraries even when fillAssetsFromSprites is false ‑ buildLibraries Should fill sounds from global libraries even when fillAssetsFromSprites is false
buildLibraries Should handle duplicate asset names in different sprites by including only one in the global library ‑ buildLibraries Should handle duplicate asset names in different sprites by including only one in the global library
buildLibraries Should handle invalid JSON files gracefully ‑ buildLibraries Should handle invalid JSON files gracefully
buildLibraries Should handle missing files gracefully ‑ buildLibraries Should handle missing files gracefully
…

♻️ This comment has been updated with latest results.

Copy link
Copy Markdown
Contributor

@KManolov3 KManolov3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@hgeorgiev-creator hgeorgiev-creator merged commit 3f834ef into develop Apr 24, 2026
11 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants