Skip to content
This repository was archived by the owner on Jun 10, 2026. It is now read-only.

fix: forces delete confirm prompt window to right side when lang = RTL#9792

Open
Fr0styGDEV wants to merge 2 commits into
scratchfoundation:developfrom
Fr0styGDEV:fixing-rtl-window
Open

fix: forces delete confirm prompt window to right side when lang = RTL#9792
Fr0styGDEV wants to merge 2 commits into
scratchfoundation:developfrom
Fr0styGDEV:fixing-rtl-window

Conversation

@Fr0styGDEV

Copy link
Copy Markdown

Resolves

Forces delete prompt window to right side when language is RTL

Reason for Changes

Better handling of window alignment for RTL languages

Browser Coverage

Tested:

Windows

  • Chrome
  • Firefox
  • Edge

@github-actions

github-actions Bot commented Dec 26, 2024

Copy link
Copy Markdown

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@Fr0styGDEV

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

@Fr0styGDEV Fr0styGDEV changed the base branch from develop to master December 26, 2024 20:39
@Fr0styGDEV Fr0styGDEV changed the base branch from master to develop December 26, 2024 20:40
@mxmou

mxmou commented Feb 1, 2025

Copy link
Copy Markdown
Contributor

I think a better way to implement this would be to change the modalPosition prop to right if isRTL is true.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Delete confirmation is on the wrong side in RTL

2 participants