Refactor renderHomepageRows to use conditional rendering#10101
Open
rosics-code wants to merge 4 commits into
Open
Refactor renderHomepageRows to use conditional rendering#10101rosics-code wants to merge 4 commits into
rosics-code wants to merge 4 commits into
Conversation
Refactor community featured projects rendering logic to handle errors gracefully.
Contributor
Author
|
@colbygk What do you think? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves:
They always go down and look ugly on the homepage.
Changes:
It changes the featured studios & projects row to be on a condition if there's no projects in it, don't show it.
Test Coverage: