Skip to content

accessibility: refactor leftover $color.ui-orange to red#10198

Open
rosics-code wants to merge 4 commits into
scratchfoundation:developfrom
rosics-code:patch-25
Open

accessibility: refactor leftover $color.ui-orange to red#10198
rosics-code wants to merge 4 commits into
scratchfoundation:developfrom
rosics-code:patch-25

Conversation

@rosics-code
Copy link
Copy Markdown
Contributor

@rosics-code rosics-code commented May 1, 2026

Resolves:

#7256

Changes:

Updates scss to swap out colors.$ui-orange; with colors.$ui-red-dark; and colors.$ui-red as orange failed WCAG guidelines.

Test Coverage:

Before with colors.$ui-orange:
Screenshot 2026-05-01 4 53 47 PM (1)

After with colors.$ui-red-dark:
Screenshot 2026-05-01 4 54 49 PM (1)

Yes WCAG AAA fails but it is better than the current color.

@cwillisf @adzhindzhi @KManolov3

@rosics-code rosics-code changed the title important: Messages count is not accessible with the orange accessibility: Messages count is not accessible with the orange May 1, 2026
@ampelc
Copy link
Copy Markdown

ampelc commented May 3, 2026

I understand this, but small changes to colours probably wont be accepted considering the ST is presumably already almost done working on the NGP

@rosics-code
Copy link
Copy Markdown
Contributor Author

I understand this, but small changes to colours probably wont be accepted considering the ST is presumably already almost done working on the NGP

I'd assume judging by how they pushed code Yesterday, WWW is still going to be used after NGP. I am going to refactor this PR to include any left over orange to turn red or red dark so it's a meaningful change.

@ampelc
Copy link
Copy Markdown

ampelc commented May 3, 2026

almost all commits since late 2023 are just dependency updates

@rosics-code
Copy link
Copy Markdown
Contributor Author

almost all commits since late 2023 are just dependency updates

They change a lot. But, hopefully ST notices this change.

@rosics-code rosics-code changed the title accessibility: Messages count is not accessible with the orange accessibility: refactor leftover $color.ui-orange to red May 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants