accessibility: refactor leftover $color.ui-orange to red#10198
Open
rosics-code wants to merge 4 commits into
Open
accessibility: refactor leftover $color.ui-orange to red#10198rosics-code wants to merge 4 commits into
rosics-code wants to merge 4 commits into
Conversation
|
I understand this, but small changes to colours probably wont be accepted considering the ST is presumably already almost done working on the NGP |
Contributor
Author
I'd assume judging by how they pushed code Yesterday, WWW is still going to be used after NGP. I am going to refactor this PR to include any left over orange to turn red or red dark so it's a meaningful change. |
|
almost all commits since late 2023 are just dependency updates |
Contributor
Author
They change a lot. But, hopefully ST notices this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves:
#7256
Changes:
Updates
scssto swap outcolors.$ui-orange;withcolors.$ui-red-dark;andcolors.$ui-redas orange failed WCAG guidelines.Test Coverage:
Before with

colors.$ui-orange:After with

colors.$ui-red-dark:Yes WCAG AAA fails but it is better than the current color.
@cwillisf @adzhindzhi @KManolov3