Skip to content

Commit 6488eb8

Browse files
committed
fix: use explicit format verb in logger middleware Printf calls
Passing a dynamic string directly as a format argument to Warnf/Errorf/Infof triggers staticcheck SA1006 and can misinterpret % characters in URL paths (e.g. %2F, %20) as format directives, producing garbled output. Use "%s" as an explicit format string instead.
1 parent 5e29491 commit 6488eb8

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

pkg/middleware/logger.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -104,11 +104,11 @@ func (lm LoggingMiddleware) Handler(next http.Handler) http.Handler {
104104

105105
switch {
106106
case lrw.StatusCode >= 400 && lrw.StatusCode <= 499:
107-
logger.Warnf(message)
107+
logger.Warnf("%s", message)
108108
case lrw.StatusCode >= 500 && lrw.StatusCode <= 599:
109-
logger.Errorf(message)
109+
logger.Errorf("%s", message)
110110
default:
111-
logger.Infof(message)
111+
logger.Infof("%s", message)
112112
}
113113
})
114114
}

0 commit comments

Comments
 (0)