Skip to content

fix: coerce dump paths to Path and mkdir before JSON export#705

Merged
andrewtavis merged 1 commit into
scribe-org:mainfrom
axif0:lastUpdate
Jul 12, 2026
Merged

fix: coerce dump paths to Path and mkdir before JSON export#705
andrewtavis merged 1 commit into
scribe-org:mainfrom
axif0:lastUpdate

Conversation

@axif0

@axif0 axif0 commented Jul 12, 2026

Copy link
Copy Markdown
Member

Contributor checklist


Description

  • Ensure output directories are created as Path objects in download scripts and add directory creation in export_formatted_data function.

  • Fixing the action for scribe-server

@axif0 axif0 requested a review from andrewtavis July 12, 2026 21:48
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for the pull request! 💙🩵

The Scribe-Data team will do our best to address your contribution as soon as we can. The following are some important points:

  • Those interested in developing their skills and expanding their role in the community should read the mentorship and growth section of the contribution guide
  • If you're not already a member of our public Matrix community, please consider joining!
    • We'd suggest that you use the Element client as well as Element X for a mobile app
    • Join the General and Data rooms once you're in
  • Also consider attending our bi-weekly Saturday developer syncs!
    • Details are shared in the General room on Matrix each Wednesday before the sync
    • It would be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions

Copy link
Copy Markdown
Contributor

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the pytest, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Great to have so many PRs from you in a day, @axif0! Always a pleasure 😊

@andrewtavis andrewtavis merged commit 552e338 into scribe-org:main Jul 12, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants